rules_python icon indicating copy to clipboard operation
rules_python copied to clipboard

Fixed unsound issue in wheel examples

Open UebelAndre opened this issue 3 years ago • 0 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [x] Bugfix
  • [ ] Feature (please, look at the "Scope of the project" section in the README.md file)
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] Other... Please describe:

What is the current behavior?

There's currently a warning in the //examples/wheel package:

WARNING: /Users/user/Code/rules_python/examples/wheel/BUILD:43:8: output 'examples/wheel/someDir' of //examples/wheel:gen_dir is a directory; dependency checking of directories is unsound

Issue Number: N/A

What is the new behavior?

The changes here fix the warning by implementing a rule to properly create the desired inputs to the examples.

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

UebelAndre avatar Aug 02 '22 14:08 UebelAndre