rules_python icon indicating copy to clipboard operation
rules_python copied to clipboard

Published 20 hours ago • verified publisher icon bazelbuild

Use alias for `copy_file` in `pip_repository` rules

Open UebelAndre opened this issue 3 years ago • 1 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] Feature (please, look at the "Scope of the project" section in the README.md file)
  • [ ] Code style update (formatting, local variables)
  • [x] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

This is a minor cleanup to help users easily identify what rules or macros are actually in use.

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

UebelAndre avatar Jan 19 '22 18:01 UebelAndre

Fine with this, but I think _copy_file = "copy_file" is the more typical way of accomplishing the same thing?

My goal was to make it obvious that the already loaded copy_file rule was unique to rules_python. If you feel strongly I can rename it but do feel ules_python_ stands out a bit more than _. Just LMK.

UebelAndre avatar Mar 01 '22 15:03 UebelAndre