rules_docker icon indicating copy to clipboard operation
rules_docker copied to clipboard

Improve documentation on `container_push`

Open davidvandebunte opened this issue 3 years ago • 4 comments
trafficstars

🚀 feature request

Description

I'm relatively new to bazel (and rules_docker) and was recently trying to push an image using container_push. It was not clear to me, as an outsider, that building the container_push target only created a script that I would need to run manually/separately. For example, it seems the user needs to run ./bazel-bin/content/push_hugo_img after building a target named push_hugo_img in the content subdirectory.

Describe the solution you'd like

There's nothing wrong with this design; only my assumption that building the target pushed the image. I expect other outsiders may have the same assumption, though, and a comment in the documentation could help.

davidvandebunte avatar Jan 16 '22 01:01 davidvandebunte

What are you doing the push the image ? Because just running the rules push the image on a registry for me.

SnipyJulmy avatar Jan 17 '22 09:01 SnipyJulmy

you should use bazel run //:your-push-target

supercairos avatar Jan 17 '22 10:01 supercairos

Ah it's bazel run rather than bazel build! That makes sense, thanks @SnipyJulmy and @supercairos.

davidvandebunte avatar Jan 17 '22 16:01 davidvandebunte

This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!

github-actions[bot] avatar Jul 17 '22 03:07 github-actions[bot]

This issue was automatically closed because it went 30 days without a reply since it was labeled "Can Close?"

github-actions[bot] avatar Aug 16 '22 03:08 github-actions[bot]