bazel icon indicating copy to clipboard operation
bazel copied to clipboard

Add `rules_rust` to recommended rules

Open UebelAndre opened this issue 3 years ago • 14 comments

Description of the feature request:

I think rules_rust fits the criteria here for becoming a recommended set of rules (https://bazel.build/rules#recommended-rules). I'm filing this issue per the guidance there as well.

UebelAndre avatar Jun 06 '22 16:06 UebelAndre

cc @hlopko, the current Googler admin for rule_rust.

UebelAndre avatar Jun 06 '22 16:06 UebelAndre

cc @alexeagle @jin

We should replace this page with a community-maintained website as we discussed with the rules SIG. Preferably something like Awesome Bazel but not bottlenecked on one maintainer.

Wyverald avatar Jun 21 '22 12:06 Wyverald

+1 @Wyverald

I think the criteria are a bit outdated (I think "No change in Bazel may break a recommended rule (with the default set of flags). If it happens, the change should be fixed or rolled back." is not followed anymore), so I don't know what the purpose of recommended rules is besides the increased visibility for Bazel newcomers.

In any case I think rules_rust do meet the criteria and I support adding them to the set of recommended rules.

hlopko avatar Jul 11 '22 07:07 hlopko

@philomathing Could we make a decision on where to host this "recommended rules" thing before 6.0? Would be nice to somewhat officially say "people, please go and look at the rules-SIG recommended list from now on".

Wyverald avatar Jul 11 '22 10:07 Wyverald

Is this depending on a 6.0 release? You could setup the external page and link to it from https://bazel.build/rules#recommended-rules later.

Can the external page be mirrored so that we can change the link in case the page goes down for any reason?

sventiffe avatar Jul 13 '22 12:07 sventiffe

We discussed this in yesterday's rules SIG meeting; I agree that it can be done any time, I just mentioned 6.0 as an arbitrary deadline since this has been dragging on for a while. On the other hand @alexeagle also seemed to think that this can wait until BCR official launch is settled since that's higher priority.

I don't think it's necessary for Google to mirror that page -- the impact of it being down is not too high (unlike mirrored download archives, etc).

Wyverald avatar Jul 13 '22 13:07 Wyverald

The BCR official launch is now complete, which is the last prerequisite mentioned on this thread. I guess we should bring this up at the SIG meeting on 24 January again.

alexeagle avatar Jan 19 '23 21:01 alexeagle

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs. If you think this issue is still relevant and should stay open, please post any comment here and the issue will no longer be marked as stale.

github-actions[bot] avatar Mar 25 '24 01:03 github-actions[bot]

I would still like this.

UebelAndre avatar Mar 26 '24 13:03 UebelAndre

We need this. We also need official Rust support in Bazel.

Emasoft avatar May 12 '24 04:05 Emasoft

What does official support mean to you?

alexeagle avatar May 13 '24 14:05 alexeagle

As a maintainer of rules_rust, it would certainly feel good to have the rules on the recommended page. Are there any reservations to including it?

UebelAndre avatar May 17 '24 12:05 UebelAndre

This has dragged on long enough -- I say we just add it to the recommended page. The "rules catalog" will come when it comes. Happy to review a PR.

Wyverald avatar May 17 '24 17:05 Wyverald

This has dragged on long enough -- I say we just add it to the recommended page. The "rules catalog" will come when it comes. Happy to review a PR.

@Wyverald Where does the change need to be made?

UebelAndre avatar May 17 '24 20:05 UebelAndre

Go to https://bazel.build/rules#recommended-rules, and click "View source"

Wyverald avatar May 20 '24 22:05 Wyverald