Colton Myers
Colton Myers
I haven't had a chance to test this yet, but can you define what you mean by "and as result transaction is aborted."? If urllib3 is indeed throwing an error...
@luipir Any luck finding some time here?
Scheduled to be merged on 2022-08-30
@beniwohli This just needs a CHANGELOG and it's ready to merge. I also opened https://github.com/elastic/apm-agent-python/issues/1548 to track the exception handling issue.
@beniwohli We should probably write some docs on this and mark it as beta since it has the exception-handling issue. Also prominently point out that known issue and link to...
Spans are only created [if the parent transaction is sampled](https://github.com/elastic/apm-agent-python/blob/8387a7d89aca43916e92e82810324890579f7a2d/elasticapm/traces.py#L690). Can you try grabbing the actual transaction object using `execution_context` like in the linked code, and check if it's set...
Show them as skipped, I think. Otherwise we'll start failing the moment that BDD tests are merged upstream, and I don't think that's the right behavior.
I think this is enforced for most things at this point. * SQL queries are shortened in [the `dbapi2` code](https://github.com/elastic/apm-agent-python/blob/00802b598cb49dc5c5c151417ddd7413a08e6339/elasticapm/instrumentation/packages/dbapi2.py#L231). * Local vars are shortened in [the client code](https://github.com/elastic/apm-agent-python/blob/00802b598cb49dc5c5c151417ddd7413a08e6339/elasticapm/base.py#L174) Obviously...
Just kidding. Found some more conversation in the cross-agent meta issue, I guess this is still in flux despite the issue-open date. Pardon my noise.
`LONG_FIELD_MAX_LENGTH` introduced in #1610 and added to Django's capture_body. First of many places.