Ed Bartosh

Results 181 comments of Ed Bartosh

In this case I'd try debootstrap or similar tool.

@klueska Thank you for the review! I've addressed most of your comments in this PR: https://github.com/pohly/kubernetes/pull/41 PTAL

@klueska Thank you for the review of the dra/plugin module! This PR https://github.com/pohly/kubernetes/pull/42 addresses your comments. Please, review.

Just wondering would it make sense to use cmd/kubeadm/app/util/output API to solve this? It would also help to unify output and implement structured output.

@neolit123 @fabriziopandini I can work on this after https://github.com/kubernetes/kubernetes/pull/75633 is merged. @tamalsaha Is it still needed for you?

@neolit123 no, I didn't have anything in particular, but I like the overall idea to have parseable output from kubeadm commands. Why not to do 'upgrade plan' if there is...

yes, the general idea is to support -o, --output yaml, json. This is what I did for 'token list'. I'll do 'kubeadm config images list' then.

@neolit123 done, please review [PR 75878](https://github.com/kubernetes/kubernetes/pull/75878)

I'll answer to your comment here. > we need to define a unified way that handles all possible output format cases in a utility function. > we don't want to...