Michał Barnaś

Results 9 comments of Michał Barnaś
trafficstars

> If the purpose is to know about high or low states only of the gpio, what is the benefit of gpio_stm32_get_config() function Exactly, the gpio_get_config should return all (supported)...

> But some of the infomation is read only and may not be used in gpio_pin_configure Sure, but if some implementation will be (more...) broken and returns the 0xffffffff, then...

> I think #48007 is another issue Yes, there seems to be a bug in the driver implementation. Both issues are connected to my PR, but definitely different root cause.

> I will modify my patch to avoid this case Thanks

> LGTM could you indicate where eSPI host emulator is currently exercised? Any available sample code I will fix this code, since some checks failed, and then I will paste...

> LGTM could you indicate where eSPI host emulator is currently exercised? Any available sample code There is code that uses the emulators: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3613913 Files that implement the tests logic...

I have refactored the PR and removed some unused code. I hope that I haven't missed any change suggestions.

> Instead of using such kind of fuzzy words, may I propose you to define more ordinal points? I know that these values are not directions, but that was the...