react-native-image-resizer icon indicating copy to clipboard operation
react-native-image-resizer copied to clipboard

Swift rewrite

Open PierreCapo opened this issue 4 years ago • 3 comments

At bamlab few people have knowledges in Objective-C.

This leads to 2 problems :

  • last code contribution of a member of bamlab (except myself was 2 years ago)
  • Close to no one was willing to maintain the repository during ~1 year

However, in bamlab we have more people who are proficient in Swift, and I think this would encourage people contributing to the project. Another point is that even people who don't know Swift can pretty easily read Swift's code and understand what the code is doing whereas Objective-C is less easy to read.

Now that Swift is pretty stable and integrates pretty well in a react-native codebase (such as in https://github.com/lottie-react-native/lottie-react-native), I have opened this PR to migrate the react-native-image-resizer from Objective-C to Swift.

The code is not totally ready yet, I'm still unsure of some part about the metadata/exif stuff. I have still release a 2.0.0-beta.0 on npm for testing purpose

cc @AntoineDoubovetzky @cristianoccazinsp @Spoutnik97

PierreCapo avatar Dec 13 '20 15:12 PierreCapo

That's great! Objective-C is awful, and although my Swift knowledge is quite basic, I will definitely help with testing the changes.

cristianoccazinsp avatar Dec 14 '20 02:12 cristianoccazinsp

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 01 '22 18:09 stale[bot]

I believe this is still a good PR, don’t let it die!

cristianoccazinsp avatar Sep 01 '22 18:09 cristianoccazinsp

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 31 '22 19:10 stale[bot]

This pull request has been automatically closed. Thank you for your contributions.

stale[bot] avatar Nov 07 '22 20:11 stale[bot]