react-native-image-resizer icon indicating copy to clipboard operation
react-native-image-resizer copied to clipboard

Make library compatible with Catalyst? AssetsLibrary not compatible

Open creambyemute opened this issue 5 years ago • 2 comments

Hey there,

It would be great if this library would be buildable for mac os with catalyst. At the moment it fails due to /Users/myUser/dev/react/myApp/node_modules/react-native-image-resizer/ios/RCTImageResizer/RCTImageResizer.m:18:9: AssetsLibrary is deprecated and is not available when building for Mac Catalyst. Consider migrating to Photos instead, or use #if !TARGET_OS_MACCATALYST to conditionally import this framework, first importing TargetConditionals.h if necessary.

There is already a PR for react-native-image-picker which has the same error: https://github.com/react-native-community/react-native-image-picker/pull/1392

Cheers

creambyemute avatar Aug 06 '20 08:08 creambyemute

Hello @creambyemute thanks for the report. Indeed this is really important and must be tackled soon. I don't have that much time right now, I'd be grateful if someone is willing to open a PR.

Thanks for the PR link of react-native-image-picker by the way, it helps a lot 😀

PierreCapo avatar Aug 06 '20 08:08 PierreCapo

@PierreCapo I might try to tackle it in the coming days

creambyemute avatar Aug 06 '20 08:08 creambyemute

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 01 '22 19:09 stale[bot]

This issue has been automatically closed. Thank you for your contributions.

stale[bot] avatar Sep 09 '22 04:09 stale[bot]