react-native-image-resizer
react-native-image-resizer copied to clipboard
Add parameter outputImageName to method createResizedImage
I added the parameter outputImageName, on method createResizedImage to allow changing the name of the resized image. Android only.
Thanks for the PR! 👍
I'm wondering if outputFilename would be a better name compared to outputImageName? As we have already outputPath, it make sense to have outputFilename. ImageName is less specific than Filename, which convey the clear meaning that is the name of the file that is created :)
What do you think? Looks good otherwise!
Ok, outputFilename better
Hi @4ian, how to resolve conflict in file index.d.ts ?
@fcostaprojects any updates on this PR? seems like it would solve this issue https://github.com/bamlab/react-native-image-resizer/issues/77
@Faolain, I'm waiting for the resolution of conflicts. But it's working correctly. Solve #77 Test directly:
"dependencies": { "react-native-image-resizer": "git+https://github.com/fcostaprojects/react-native-image-resizer.git", ..... }
@4ian any suggestions on how fcostaprojects can resolve his typescript/flow conflicts?
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This pull request has been automatically closed. Thank you for your contributions.