react-native-image-resizer icon indicating copy to clipboard operation
react-native-image-resizer copied to clipboard

Add parameter outputImageName to method createResizedImage

Open fcostaprojects opened this issue 8 years ago • 6 comments

I added the parameter outputImageName, on method createResizedImage to allow changing the name of the resized image. Android only.

fcostaprojects avatar Nov 06 '17 22:11 fcostaprojects

Thanks for the PR! 👍 I'm wondering if outputFilename would be a better name compared to outputImageName? As we have already outputPath, it make sense to have outputFilename. ImageName is less specific than Filename, which convey the clear meaning that is the name of the file that is created :) What do you think? Looks good otherwise!

4ian avatar Nov 06 '17 22:11 4ian

Ok, outputFilename better

fcostaprojects avatar Nov 06 '17 23:11 fcostaprojects

Hi @4ian, how to resolve conflict in file index.d.ts ?

fcostaprojects avatar Jan 06 '18 15:01 fcostaprojects

@fcostaprojects any updates on this PR? seems like it would solve this issue https://github.com/bamlab/react-native-image-resizer/issues/77

Faolain avatar Jan 21 '19 09:01 Faolain

@Faolain, I'm waiting for the resolution of conflicts. But it's working correctly. Solve #77 Test directly:

"dependencies": { "react-native-image-resizer": "git+https://github.com/fcostaprojects/react-native-image-resizer.git", ..... }

fcostaprojects avatar Jan 21 '19 12:01 fcostaprojects

@4ian any suggestions on how fcostaprojects can resolve his typescript/flow conflicts?

Faolain avatar Mar 06 '19 03:03 Faolain

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 01 '22 18:09 stale[bot]

This pull request has been automatically closed. Thank you for your contributions.

stale[bot] avatar Sep 08 '22 18:09 stale[bot]