ballerina-lang icon indicating copy to clipboard operation
ballerina-lang copied to clipboard

Published 20 hours ago • verified publisher icon ballerina-platform

Improve sorting in `From Clause Node` completions

Open LakshanWeerasinghe opened this issue 3 years ago • 1 comments

Purpose

$subject update the sort logic for query completions.

Fixes #36482

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • [x] Read the Contributing Guide
  • [ ] Updated Change Log
  • [ ] Checked Tooling Support (#<Issue Number>)
  • [x] Added necessary tests
    • [x] Unit Tests
    • [ ] Spec Conformance Tests
    • [ ] Integration Tests
    • [ ] Ballerina By Example Tests
  • [x] Increased Test Coverage
  • [ ] Added necessary documentation
    • [ ] API documentation
    • [ ] Module documentation in Module.md files
    • [ ] Ballerina By Examples

LakshanWeerasinghe avatar Jul 19 '22 02:07 LakshanWeerasinghe

Codecov Report

Base: 74.68% // Head: 74.71% // Increases project coverage by +0.02% :tada:

Coverage data is based on head (e21cbe9) compared to base (6270273). Patch coverage: 88.26% of modified lines in pull request are covered.

Additional details and impacted files 
@@              Coverage Diff               @@
##             2201.2.x   #37051      +/-   ##
==============================================
+ Coverage       74.68%   74.71%   +0.02%     
- Complexity      50177    50230      +53     
==============================================
  Files            3339     3339              
  Lines          193530   193702     +172     
  Branches        25313    25348      +35     
==============================================
+ Hits           144535   144716     +181     
+ Misses          40640    40626      -14     
- Partials         8355     8360       +5
Impacted Files Coverage Δ
.../io/ballerina/projects/SyntaxNodeAnalysisTask.java 85.71% <0.00%> (-4.29%) :arrow_down:
...pletions/providers/AbstractCompletionProvider.java 92.70% <ø> (ø)
...oviders/context/TemplateExpressionNodeContext.java 76.47% <0.00%> (-2.32%) :arrow_down:
...alang/langserver/completions/util/SortingUtil.java 69.68% <ø> (ø)
.../context/ListConstructorExpressionNodeContext.java 88.00% <50.00%> (-3.31%) :arrow_down:
...ava/io/ballerina/projects/CodeModifierManager.java 71.60% <60.52%> (-0.62%) :arrow_down:
...ngserver/completions/util/ContextTypeResolver.java 75.12% <85.41%> (+1.78%) :arrow_up:
...a/io/ballerina/jsonmapper/util/ConverterUtils.java 90.66% <96.15%> (+6.18%) :arrow_up:
...llerina/projects/SyntaxNodeAnalysisTaskRunner.java 100.00% <100.00%> (ø)
...tions/providers/context/FromClauseNodeContext.java 89.23% <100.00%> (+1.73%) :arrow_up:
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Aug 03 '22 07:08 codecov[bot]

@LakshanWeerasinghe shall we address the review comments here

IMS94 avatar Aug 19 '22 15:08 IMS94

@malinthar Need your review to merge this.

mohanvive avatar Aug 30 '22 04:08 mohanvive