volsync icon indicating copy to clipboard operation
volsync copied to clipboard

Published 20 hours ago • verified publisher icon backube

Add support for using a custom CA w/ restic mover

Open JohnStrunk opened this issue 3 years ago • 5 comments

Describe what this PR does This adds the ability to provide a Secret & key w/in that Secret that holds a custom ca.crt which will be passed to restic to verify the connection to the backup repo.

Is there anything that requires special attention?

Related issues: Fixes #348

JohnStrunk avatar Aug 26 '22 19:08 JohnStrunk

/hold Still needs docs

JohnStrunk avatar Aug 26 '22 19:08 JohnStrunk

/unhold Docs added

JohnStrunk avatar Aug 26 '22 20:08 JohnStrunk

Codecov Report

Merging #398 (5402878) into main (396654f) will decrease coverage by 0.0%. The diff coverage is 54.7%.

Additional details and impacted files 
@@           Coverage Diff           @@
##            main    #398     +/-   ##
=======================================
- Coverage   64.1%   64.0%   -0.1%     
=======================================
  Files         44      44             
  Lines       5104    5155     +51     
=======================================
+ Hits        3273    3301     +28     
- Misses      1634    1657     +23     
  Partials     197     197
Impacted Files Coverage Δ
controllers/mover/restic/mover.go 73.8% <51.0%> (-3.3%) :arrow_down:
controllers/mover/restic/builder.go 88.7% <100.0%> (+0.4%) :arrow_up:

codecov[bot] avatar Aug 26 '22 22:08 codecov[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.3% 2.3% Duplication

sonarqubecloud[bot] avatar Sep 01 '22 12:09 sonarqubecloud[bot]

/cc @tesshuflower

JohnStrunk avatar Sep 06 '22 12:09 JohnStrunk

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnStrunk, tesshuflower

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [JohnStrunk,tesshuflower]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Sep 06 '22 13:09 openshift-ci[bot]