symja_android_library icon indicating copy to clipboard operation
symja_android_library copied to clipboard

[External] Replace embedded tablesaw.plotly by Maven dependencies (#265)

Open HannesWell opened this issue 3 years ago • 2 comments

Description

This PR (part of #265) replaces the source code of source code of the tablesaw-jsplot sub-project embedded in matheclipse-external with a corresponding Maven dependency.

The Maven coordinates used are:

	<dependency>
		<groupId>tech.tablesaw</groupId>
		<artifactId>tablesaw-jsplot</artifactId>
		<version>0.42.0</version>
	</dependency>

The tablesaw sources embedded in matheclipse-io are not affected.

@axkr is there a reason to not use a Maven dependency? In contrast to the sources of tablesaw in matheclipse-io those embedded in matheclipse-external seem not to have matheclipse references?

HannesWell avatar Jan 09 '22 21:01 HannesWell

gitpod-io[bot] avatar Jan 09 '22 21:01 gitpod-io[bot]

I just noticed that tablesaw-jsplot has a transitive dependency to tablesaw-core which is partially embedded into matheclipse-io. I assume only the part not depending on tablesaw-core was embedded into matheclipse-core. So I suggest to request changes to the tablesaw project so tablesaw can be made a complete Maven-dependency for core and io and issue #265 can be resolved entirely.

HannesWell avatar Jan 09 '22 23:01 HannesWell