aws-cloudformation-user-guide icon indicating copy to clipboard operation
aws-cloudformation-user-guide copied to clipboard

Published 20 hours ago • verified publisher icon awsdocs

Missing " in AWS::Route53Resolver::ResolverRule example

Open w0rmr1d3r opened this issue 3 years ago • 1 comments

AWS::Route53Resolver::ResolverRule is missing a " in the JSON example.

Link to the JSON example -> https://github.com/awsdocs/aws-cloudformation-user-guide/blob/main/doc_source/aws-resource-route53resolver-resolverrule.md#json-1 The second IP in TargetIps is missing the ":

      {
        "Ip" : "192.0.2.99,  <-- there
        "Port" : "53"
      }

happy to open a PR if needed

w0rmr1d3r avatar Apr 28 '22 09:04 w0rmr1d3r

PR with the fix -> https://github.com/awsdocs/aws-cloudformation-user-guide/pull/1211

w0rmr1d3r avatar Apr 29 '22 09:04 w0rmr1d3r

Thank you for reporting the issue. It has been corrected.

HLeeHart avatar Apr 02 '23 21:04 HLeeHart

Thank you @HLeeHart for answering. My PR though is still open and it doesn't have any conflicts with the base branch. Does it need merging or closing? thank you

w0rmr1d3r avatar Apr 03 '23 13:04 w0rmr1d3r