aws-cli

aws-cli copied to clipboard

Issue #, if available: Closes #4837

Description of changes: Analogous to #4420. I believe this should be safe now that aws-cli has dropped support for python 3.4? (ref https://docutils.sourceforge.io/HISTORY.html#release-0-16)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks @tkelman. It looks like 0.17 is still in pre-release. We would need to wait for a final release and then test it out internally.

Correct @kdaily, but I'm keeping it a strict upper bound here, and 0.16 was released Jan 12, 2020. Would you rather bump the strict upper bound by 2 versions later, or do it in two changes?

Would you rather bump the strict upper bound by 2 versions later, or do it in two changes?

~~And if it's the latter, does the first change (the current version of this PR) need to wait until the next awscli minor release?~~

I'll assume by a lack of response that the answer is yes? docutils 0.17 was released April 3rd, updated.

Ping again on this, what's needed to merge? I see the s3transfer dependency bounds (lower too, not just upper) changed minor version during a patch release of awscli.

docutils versions 0.16 (released Jan 12 2020), 0.17 (released Apr 3 2021), and 0.17.1 (released Apr 17 2021) are all blocked by the existing upper bounds.

Codecov Report

Merging #6011 (fac8077) into develop (4153da2) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #6011   +/-   ##
=======================================
  Coverage     0.08%   0.08%           
=======================================
  Files          208     208           
  Lines        16539   16539           
=======================================
  Hits            14      14           
  Misses       16525   16525           

Hi @tkelman, appreciate you keeping on this. It is in our backlog, but we have not yet reviewed the changes made in docutils. I don't have a timeline on when that will happen, unfortunately.

Hi @kdaily, it looks like docutils current version of 0.17.1 is a full release. Any chance we could get this change merged into awscli?

docutils 0.18 ~~is also in pre-release right now~~ has been released as well

@nateprewitt @kdaily (from https://github.com/aws/aws-cli/issues/5943 and https://github.com/aws/aws-cli/issues/4837)

Is there anything blocking this dep update?

@nateprewitt @kdaily (from #5943 and #4837)

Is there anything blocking this dep update?

I think there is nothing pending that blocks it.

A dependency that is limited above to a version that was released two years ago is still a problem... 😔

It is also another recent PR with the same change https://github.com/aws/aws-cli/pull/7384

+1

Worth noting that #7384 has the advantage that it was auto-generated by dependabot, but that PR is against the v2 branch so it would separately need to be backported to awscli v1.

Closing in favor of newer dependabot PRs.

It looks to me like those dependabot PR's that are against v1 (develop) may need some manual tweaking to also update setup.cfg