aws-control-tower-customizations icon indicating copy to clipboard operation
aws-control-tower-customizations copied to clipboard

Incorrect parameter_value parsing when comma is present

Open lapkritinis opened this issue 3 years ago • 1 comments

Describe the bug When deploying CFT if parameter is specified like this:

      - parameter_key: RoleType
        parameter_value: 'Standard (read only, custom policy)'

Parameter value gets modified to 'Standard (read only,custom policy)' (space gets removed)

To Reproduce Try launch template with such block:

Parameters:
  RoleType:
    Type: String
    AllowedValues:
      - Standard (read only, custom policy)
      - Standard-Managed (read only, AWS managed policy)

Expected behavior It should pick specified value

Please complete the following information about the solution:

  • [ ] Version: 2.5.1

lapkritinis avatar Oct 25 '22 20:10 lapkritinis

Thanks for bringing this to our attention @lapkritinis. This is actually a side effect it seems of the way we look for lists for parameter_value, I'll create a backlog with the team to discuss this.

balltrev avatar Oct 31 '22 21:10 balltrev