aws-cudos-framework-deployment icon indicating copy to clipboard operation
aws-cudos-framework-deployment copied to clipboard

Published 20 hours ago • verified publisher icon aws-samples

fix: activate SPLIT_COST_ALLOCATION_DATA option

Open MaximF opened this issue 1 year ago • 1 comments

Issue #, if available:

Description of changes: Activate SPLIT_COST_ALLOCATION_DATA option

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

MaximF avatar May 02 '24 01:05 MaximF

@iakov-aws could you please take a look and let me know if that would be a good addition to your PR https://github.com/aws-samples/aws-cudos-framework-deployment/pull/794?

MaximF avatar May 02 '24 17:05 MaximF

@iakov-aws and @sean-nixon could you please take another look at this PR?

MaximF avatar May 09 '24 20:05 MaximF

Terraform code looks good to me. We'll just want to update the module README files to document the new variable.

sean-nixon avatar May 09 '24 22:05 sean-nixon

Thanks @sean-nixon! I just updated README files and also explicitly defined the variable type as bool. Take a look please.

MaximF avatar May 10 '24 07:05 MaximF

Great! Thank you for reviewing it @sean-nixon! @iakov-aws can we merge it today please?

MaximF avatar May 10 '24 16:05 MaximF