aws-cudos-framework-deployment icon indicating copy to clipboard operation
aws-cudos-framework-deployment copied to clipboard

Fixed inconsistency when creating account_map view

Open dnabic-aws opened this issue 2 years ago • 3 comments

Description of changes:

  • Changes related to creation of account_map from cid-cmd
    • SQL query for creation of view account_map as organization is moved from code into file cid/builtin/core/data/queries/shared/account_map_org.sql
    • Column names for view account_map are the same when this view is created as dummy and as organization
    • account_email_id column name is removed as it is not used anywhere

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

dnabic-aws avatar Feb 21 '23 07:02 dnabic-aws

This PR seems stale? I ran into this issue when using the cid-cmd map --account-map-source to create mappings from CSV. Had to update views and datasets because of errors.

jannyg avatar Feb 28 '24 13:02 jannyg

This PR seems stale? I ran into this issue when using the cid-cmd map --account-map-source to create mappings from CSV. Had to update views and datasets because of errors.

Hi Please can you provide more info regarding your issue? This PR was not compatible with update procedure so we put it on hold.

iakov-aws avatar Feb 28 '24 14:02 iakov-aws

This PR seems stale? I ran into this issue when using the cid-cmd map --account-map-source to create mappings from CSV. Had to update views and datasets because of errors.

Hi Please can you provide more info regarding your issue? This PR was not compatible with update procedure so we put it on hold.

I'm new to CUDOS and QuickSight so I'll try to explain as good as I can :)

After running the command (installed latest with pip) on CUDOS v0.2.46 the datasets in QuickSight failed with column errors (account_email_id not found) or STALE (mismatch between number of columns).

[Simba][AthenaJDBC](100071) An error has been thrown from the AWS Athena client. COLUMN_NOT_FOUND: line 12:227: Column 'account_email_id' cannot be resolved or requester is not authorized to access requested resources [Execution ID: 3e3864e5-59cf-44ec-a837-dff9c7a792fe]

I had to manually update all the views in Athena and refresh and publish the datasets in QuickSight to resolve the issue. I also have some NULL values in the dashboard. It seems like there could be some accounts maybe missing, so I will check that first. But I was expecting the behavior for mapping to show account number if no account_name was found.

jannyg avatar Feb 29 '24 08:02 jannyg