aws-otel-java-instrumentation icon indicating copy to clipboard operation
aws-otel-java-instrumentation copied to clipboard

Published 20 hours ago • verified publisher icon aws-observability

Adding support for ISO regions

Open atshaw43 opened this issue 1 year ago • 2 comments

Description of changes: Adding support for ISO regions in the remote target for SQS. Added additional validation for region and account id. Fixed some tests. The testing logic that already existed was busted because if the target compared to was null it didn't validate it.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

atshaw43 avatar Feb 16 '24 22:02 atshaw43

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.83%. Comparing base (09e6487) to head (f0b14b8). Report is 246 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@              Coverage Diff              @@
##               main     #751       +/-   ##
=============================================
- Coverage     85.71%   52.83%   -32.88%     
- Complexity       19      319      +300     
=============================================
  Files             3       40       +37     
  Lines            49     1446     +1397     
  Branches          5      180      +175     
=============================================
+ Hits             42      764      +722     
- Misses            3      635      +632     
- Partials          4       47       +43

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 16 '24 23:02 codecov-commenter

This PR is stale because it has been open 60 days with no activity.

github-actions[bot] avatar May 05 '24 20:05 github-actions[bot]

No longer pursuing this.

thpierce avatar Aug 29 '24 17:08 thpierce