aws-otel-java-instrumentation icon indicating copy to clipboard operation
aws-otel-java-instrumentation copied to clipboard

Published 20 hours ago • verified publisher icon aws-observability

Run contract tests with no cache

Open vasireddy99 opened this issue 1 year ago • 5 comments

Description of changes:

Currently contract tests are cached on main-build, this pr changes to run on no cache

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

vasireddy99 avatar Feb 03 '24 06:02 vasireddy99

Codecov Report

Attention: 102 lines in your changes are missing coverage. Please review.

Comparison is base (09e6487) 85.71% compared to head (92e8e4b) 50.73%. Report is 234 commits behind head on main.

Files Patch % Lines
...ent/providers/AwsAppSignalsCustomizerProvider.java 24.00% 35 Missing and 3 partials :warning:
...gent/providers/AwsSpanMetricsProcessorBuilder.java 0.00% 20 Missing :warning:
...ders/AttributePropagatingSpanProcessorBuilder.java 0.00% 16 Missing :warning:
...viders/AwsMetricAttributesSpanExporterBuilder.java 0.00% 11 Missing :warning:
...try/javaagent/providers/AwsSpanProcessingUtil.java 90.16% 1 Missing and 5 partials :warning:
...vaagent/providers/AwsMetricAttributeGenerator.java 96.89% 2 Missing and 3 partials :warning:
...y/javaagent/providers/AwsSpanMetricsProcessor.java 91.48% 0 Missing and 4 partials :warning:
...t/providers/AttributePropagatingSpanProcessor.java 94.59% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@              Coverage Diff              @@
##               main     #739       +/-   ##
=============================================
- Coverage     85.71%   50.73%   -34.99%     
- Complexity       19      264      +245     
=============================================
  Files             3       39       +36     
  Lines            49     1301     +1252     
  Branches          5      141      +136     
=============================================
+ Hits             42      660      +618     
- Misses            3      609      +606     
- Partials          4       32       +28

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 03 '24 07:02 codecov-commenter

Why is this necessary?

bryan-aguilar avatar Feb 28 '24 18:02 bryan-aguilar

Why is this necessary?

In one of the workflows the contract tests are cached and it didn't run, this makes sure that we run contract tests neverthless.

vasireddy99 avatar Feb 28 '24 18:02 vasireddy99

This PR is stale because it has been open 60 days with no activity.

github-actions[bot] avatar Apr 28 '24 20:04 github-actions[bot]