aws-otel-java-instrumentation icon indicating copy to clipboard operation
aws-otel-java-instrumentation copied to clipboard

Published 20 hours ago • verified publisher icon aws-observability

Veirfy ADOT Image changed if applicable

Open XinRanZhAWS opened this issue 1 year ago • 4 comments

Description of changes: If ADOT image have been updated via Patch, add a verification step to make sure the Image does updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

XinRanZhAWS avatar Dec 27 '23 20:12 XinRanZhAWS

https://github.com/XinRanZhAWS/aws-otel-java-instrumentation/actions/runs/7619155854 Test to shows it functional attached

XinRanZhAWS avatar Jan 23 '24 19:01 XinRanZhAWS

Codecov Report

Attention: 102 lines in your changes are missing coverage. Please review.

Comparison is base (09e6487) 85.71% compared to head (1aa4117) 50.73%. Report is 233 commits behind head on main.

Files Patch % Lines
...ent/providers/AwsAppSignalsCustomizerProvider.java 24.00% 35 Missing and 3 partials :warning:
...gent/providers/AwsSpanMetricsProcessorBuilder.java 0.00% 20 Missing :warning:
...ders/AttributePropagatingSpanProcessorBuilder.java 0.00% 16 Missing :warning:
...viders/AwsMetricAttributesSpanExporterBuilder.java 0.00% 11 Missing :warning:
...try/javaagent/providers/AwsSpanProcessingUtil.java 90.16% 1 Missing and 5 partials :warning:
...vaagent/providers/AwsMetricAttributeGenerator.java 96.89% 2 Missing and 3 partials :warning:
...y/javaagent/providers/AwsSpanMetricsProcessor.java 91.48% 0 Missing and 4 partials :warning:
...t/providers/AttributePropagatingSpanProcessor.java 94.59% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@              Coverage Diff              @@
##               main     #678       +/-   ##
=============================================
- Coverage     85.71%   50.73%   -34.99%     
- Complexity       19      264      +245     
=============================================
  Files             3       39       +36     
  Lines            49     1301     +1252     
  Branches          5      141      +136     
=============================================
+ Hits             42      660      +618     
- Misses            3      609      +606     
- Partials          4       32       +28

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 23 '24 20:01 codecov-commenter

Please run another test with a value given for the input appsignals-adot-image-name so we can see the behaviour when the ADOT image is changed.

majanjua-amzn avatar Feb 08 '24 17:02 majanjua-amzn

This PR is stale because it has been open 60 days with no activity.

github-actions[bot] avatar Apr 14 '24 22:04 github-actions[bot]

This code is gone. Closing.

thpierce avatar Aug 29 '24 19:08 thpierce