terraform-aws-eks-blueprints-addons icon indicating copy to clipboard operation
terraform-aws-eks-blueprints-addons copied to clipboard

fix: Update cert-manager to use crds.enabled instead of the deprecated installCRDs option

Open kinyat opened this issue 8 months ago • 3 comments

What does this PR do?

This is a follow-up to https://github.com/aws-ia/terraform-aws-eks-blueprints-addons/pull/435.

Instead of changing the option directly, we add a pre-check before setting installCRDs.

If the user has already set the new crds.enabled flag in either values or set, we do not add the deprecated installCRDs option.

This helps prevent breaking changes and allows users to avoid the deprecated installCRDs option.

Update: Follow-up to https://github.com/aws-ia/terraform-aws-eks-blueprints-addons/pull/443#pullrequestreview-2633785239

I have updated the PR to pump up the version of the cert-manager to the latest minor version.

I have also updated the PR to remove the usage of installCRDs and replaced it with both the new crds.enabled and crds.keep options.

Motivation

  • Resolves https://github.com/aws-ia/terraform-aws-eks-blueprints-addons/issues/420

More

  • [ ] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • [ ] Yes, I ran pre-commit run -a with this PR

For Moderators

  • [ ] E2E Test successfully complete before merge?

Additional Notes

kinyat avatar Feb 21 '25 02:02 kinyat