terraform-aws-eks-blueprints-addons

terraform-aws-eks-blueprints-addons copied to clipboard

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted. Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

Since v0.33 it is recommended to deploy karpenter in the kube-system namespace

• Resolves #383

More

• [x] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
• [x] Yes, I ran pre-commit run -a with this PR

For Moderators

• [ ] E2E Test successfully complete before merge?

Additional Notes

How was this change tested and validated?

I have tested this locally when using the eks blueprints addons to migrate karpenter to the kube-system namespace. Also validated karpenter was not affecting any workloads after this and workloads were success.

and its not reporting any errors by Helm trying to create the existing namespace? https://github.com/aws-ia/terraform-aws-eks-blueprints-addons/blob/7755fb6ec97139d34b7d01467ce7f20164cbd24a/main.tf#L3022C40-L3022C56

and its not reporting any errors by Helm trying to create the existing namespace? https://github.com/aws-ia/terraform-aws-eks-blueprints-addons/blob/7755fb6ec97139d34b7d01467ce7f20164cbd24a/main.tf#L3022C40-L3022C56

It didn't.

I'm debating if this should be marked as breaking changes, as if there are other dependencies users might have on the karpenter namespace, such as scraping metrics from the karpenter controller, they should be aware that we changed the namespace.

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

Pull request closed due to inactivity.