terraform-aws-eks-blueprints-addons

terraform-aws-eks-blueprints-addons copied to clipboard

Description

In the velero template there are a LOT of defaults populated via the set list. One of these is the prefix which is taken from the s3_backup_location using a split on /. This is coded to only take the first result, so any nested prefix is truncated e.g. 'foo/bar' becomes foo. This would not be a problem except that I cannot override it by setting it myself in the values; it keeps creating it using the result of the split. Can we either allow the prefix to be more than one level deep; or provide a way to override, or to switch off, the use of the set so I can do it myself.

I used to be able to do this in the previous version of blueprints v4.32.1 !

If your request is for a new feature, please use the Feature request template. I don't consider this a feature request at this time as the blueprint should at the very least provide a method to override the default method of specifying the prefix.

• [ x] ✋ I have searched the open/closed issues and my issue is not listed.

Versions

• Module version [Required]: 1.11.0

• Terraform version: 1.6.3

Reproduction Code [Required]

enable_velero = true
  velero        = {
    s3_backup_location = "arn:aws:s3:::${data.aws_caller_identity.current.account_id}-software-platforms/foo/bar"
    values             = [templatefile("${path.module}/helm_values/velero.yaml", {
      prefix                    = "foo/bar"
    })]

velero.yaml

configuration:
  backupStorageLocation:
    prefix: ${prefix}

Result is always:

objectStorage:
    bucket: XXXXXXXXXXXX-software-platforms
    prefix: foo

Expect:

objectStorage:
    bucket: XXXXXXXXXXXX-software-platforms
    prefix: foo/bar

Steps to reproduce the behaviour:

Try to install velero with a nested prefix (i.e. a prefix containing a /); either via s3_backup_location or values.

Expected behaviour

Either the prefix should include my entire value e.g. foo/bar OR I should be able to override the generated prefix via the values OR have the ability to off the set entirely.

Actual behaviour

My prefix is stripped so I end up with foo instead of foo/bar AND I cannot override it via values.

Terminal Output Screenshot(s)

N/A

Additional context

N/A

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

Issue closed due to inactivity.