Brandon Dail
Brandon Dail
Since `defaultMuted` is already a spec-defined property reflecting the `muted` attribute, it would make sense to let users utilize this API. The React API is already property-focused, so it's not...
I'm hesitant to change `muted` to act like `value`; we want to get away from that special-cased behavior, since it's caused a number of problems. Of course, `muted` would likely...
> I like that idea, tho It's always a slippery slope, what would the SSR behavior if someone specifies defaultMuted but no muted, ? I suppose we already handle this...
My assumption is that the one use case for `defaultMuted` is to handle the situation where the `muted` attribute should be present when the video is first rendered. Since it...
It could be just as easy as adding it to this list: https://github.com/facebook/react/blob/1c2876d5b558b8591feb335d8d7204bc46f7da8a/packages/react-dom/src/shared/DOMProperty.js#L305-L322
@tonix-tuft is there any way you can reproduce the issue without the TransOver extension? It seems likely that the extension is doing something other than just appending an element to...
> So, even if codespan-reporting doesn't change the FileId requirement or include something like the above itself, you should still be able to achieve something like what you want. Yeah...
@brendanzab would you be open to including some LSP utilities in `codespan-reporting`? It might make sense to have `codespan_reporting::lsp` to mirror the `codespan_reporting::term` backend. I'd be happy to help here...
@djskinner your second test uses `shallow` in the failing test case when it should use `mount`. Can you verify it actually fails with `mount`? I wouldn't expect it to, as...
Thank for verifying!