react-shortcuts icon indicating copy to clipboard operation
react-shortcuts copied to clipboard

Update example, tests and dependecies for react 16 support

Open dimapaloskin opened this issue 8 years ago • 3 comments

Hello.

I updated dependencies, example and tests for supporting new react 16.

What do you think about it?

dimapaloskin avatar Oct 05 '17 10:10 dimapaloskin

I'm interested in getting rid of the yarn warnings about the peerDependency on react when using react v16. Is this PR still in the pipes?

guillaume86 avatar Nov 01 '17 16:11 guillaume86

@petrbrzek @dimapaloskin can we move this forward in order to officially support react 16?

mistic avatar Nov 02 '18 16:11 mistic

The problem with this PR is that it is trying to do too much. The only thing that needs to change (to make end-users of this library happy) is to update package.json with

  "peerDependencies": {
    "react": ">=0.14.8",
    "react-dom": ">=0.14.8"
  }

krow-ten avatar Mar 23 '19 09:03 krow-ten