HPOBench icon indicating copy to clipboard operation
HPOBench copied to clipboard

Make installable for Python 3.10.6

Open dwoiwode opened this issue 3 years ago • 6 comments

Due to following line, HPOBench is no installable for Python 3.10.6. I use HPOBench in the test cases of my package (pyPDPPartitioner) and therefore need to install HPOBench in the test-pipeline. This fails, as this line prohibits the installation.

There are a few workarounds for me:

  1. Change python_requires='>=3.6, <=3.10' to python_requires='>=3.6, <3.11', which just stalls the issue (Currently done in this branch)
  2. Remove upper python boundary so that python_requires='>=3.6, <=3.10' will be python_requires='>=3.6'
  3. Remove HPOBench in my test cases/dependencies

Personally, I do not think there is an issue with the second approach, although this might be untested in future python versions

dwoiwode avatar Aug 09 '22 21:08 dwoiwode

I think approach 2. is best, there's rarely ever a reason to upper bound a python version

eddiebergman avatar Aug 10 '22 10:08 eddiebergman

Hi,

thanks for your pull request. Approach 2 is also fine by me.

Could you also please redirect the PR to the development branch?

Thanks

PhMueller avatar Aug 10 '22 15:08 PhMueller

Codecov Report

Merging #155 (02b217d) into development (4c4f1d9) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #155   +/-   ##
============================================
  Coverage        42.23%   42.23%           
============================================
  Files               46       46           
  Lines             2671     2671           
============================================
  Hits              1128     1128           
  Misses            1543     1543           

codecov[bot] avatar Aug 11 '22 09:08 codecov[bot]

Looks like the python versions were interpreted as floats instead of strings. I hope the latest commit fixes this

dwoiwode avatar Aug 11 '22 10:08 dwoiwode

I think the build for python 3.10 crashes due some old (unnecessary) dependencies that we have in the HPOBench. We are planing to remove them with the next release (coming end of september). This should fix the error above. We also will include the support for py>=3.10 then.

PhMueller avatar Aug 29 '22 06:08 PhMueller

We have a similar issue in auto-sklearn, the problem is essentially the scikit learn version. Scikit learn needs an older version of numpy which doesn't release a pre-built wheel for python 3.10. Therefore, it downloads the older version of numpy and tries to build it for python 3.10 and then fails.

eddiebergman avatar Aug 29 '22 09:08 eddiebergman

Hey, thanks for your work. I have fixed the remaining error in #155 on our side and included your changes into the dev branch.

Therefore, i close this PR.

PhMueller avatar Sep 28 '22 09:09 PhMueller