tippyjs icon indicating copy to clipboard operation
tippyjs copied to clipboard

Export the SCSS please

Open iamnewton opened this issue 5 years ago • 5 comments

Problem

Currently, the only way to implement the styles is via a CDN link and/or using the compiled CSS files. In cases where you're rolling your own build process, importing CSS files into SCSS is not ideal as there is easy way to extend out the themes.

Solution

Update the package.json to include the src directory of SCSS files

iamnewton avatar May 26 '20 18:05 iamnewton

I don't think the SCSS files are ready for theming, they need a !default and maybe some other fixes. If you send a PR to fix this we can export them, I'm not sure what to do.

atomiks avatar May 28 '20 06:05 atomiks

@atomiks I would love to help out; with new features in dart-sass, theming should be relatively straightforward to add. I'll see if I can't get something together.

iamnewton avatar May 28 '20 21:05 iamnewton

Any news to this? :)

strarsis avatar Feb 12 '21 13:02 strarsis

I'm trying to get some time to do this; might be able to tackle this week, but no promises.

iamnewton avatar Feb 17 '21 04:02 iamnewton

@atomiks as I'm looking through the code, is it possible for you (could be me in a PR) to add src to the files directive in the package.json so that the SCSS files are exposed? I'm looking at the source code for the SCSS and it appears you're doing a lot of complicated work to bundle the SCSS to CSS using JS, when, in fact, a consumer of the SCSS would only need access to the source files themselves and maybe some documentation on which files to include.

iamnewton avatar Feb 17 '21 18:02 iamnewton