tippyjs Update `appendTo` docs to be inline with code/other docs

Update `appendTo` docs to be inline with code/other docs

Open jasikpark opened this issue 3 years ago • 6 comments

https://github.com/atomiks/tippyjs/blob/60aee16c934fc861569f84a37c6a1a7f42a33fa0/src/constants.ts#L12

This is a docs change to update the description of the default setting for appendTo

Jan 07 '22 15:01 jasikpark

The current docs are correct as the condition is "If interactive: true"

Jan 08 '22 12:01 atomiks

Oh! I didn't see that at all 😅 It looked like the default in the text and the default in the example code described two different defaults

Jan 08 '22 16:01 jasikpark

Yeah tbh the wording could be better. Like describe the actual default, then the default with the condition.

Jan 08 '22 16:01 atomiks

I'll update my PR w/ that wording if that works! That seems like a good way to make it less confusing to me :)

Jan 10 '22 19:01 jasikpark

Only took me 7mo to update 😅

Aug 22 '22 15:08 jasikpark

anything i can do to push this PR to being merged?

May 16 '23 15:05 jasikpark