atomic-server icon indicating copy to clipboard operation
atomic-server copied to clipboard

Published 20 hours ago • verified publisher icon atomicdata-dev

Use JSON Canonicalization Scheme (JCS)

Open joepio opened this issue 4 years ago • 3 comments

Although the tests are currently passing, and most commits seem to work just fine, I'm pretty sure that there will be situations where the deterministic json-ad serialization will be different from the Typescript version.

To prevent this, I should switch to serde_jcs. Also, double check in atomic-data-browser that this spec is used as well.

Also https://docs.rs/serde_canonical_json/latest/serde_canonical_json/

joepio avatar Mar 18 '21 22:03 joepio

Also, maybe use JSON Web Signature encoding? https://crates.io/crates/jws

See https://github.com/ontola/atomic-data/issues/35

joepio avatar Mar 29 '21 16:03 joepio

Also, don't use base64 in URLs (because of =, / characters), maybe consider base64URL

joepio avatar Apr 25 '21 14:04 joepio

I used serde_canonical_json. Not sure it is actually JCS, though: https://github.com/gelvinp/rs-serde_canonical_json/issues/1

EDIT: switched to serde_jcs because the other one wasnt JCS.

joepio avatar Jan 09 '24 13:01 joepio