react-beautiful-dnd icon indicating copy to clipboard operation
react-beautiful-dnd copied to clipboard

Fix style reflow

Open joseffsmith opened this issue 4 years ago • 4 comments

Changing user-select on the body element forces a style reflow for all elements in the body, this fixes that by only applying the user-select: none to the draggable element, this has the same intended effect.

You can see here in the MDN docs for user-select that clicking on an element with user-select: none and trying to highlight any other text by dragging around does not highlight any other text.

https://developer.mozilla.org/en-US/docs/Web/CSS/user-select#result

Fixes: #1850

joseffsmith avatar Oct 05 '21 12:10 joseffsmith

Hooray! All contributors have signed the CLA.

atlassian-cla-bot[bot] avatar Oct 05 '21 12:10 atlassian-cla-bot[bot]

Would someone be able to rerun the ci/circleci: test-a11y test, looks like it failed with a connection issue

joseffsmith avatar Oct 05 '21 14:10 joseffsmith

Looking forward to see this merged so I am able to improve a performance of my feature a lot!

schichulin avatar Oct 06 '21 08:10 schichulin

This is still an issue in 2023. Is there some blocking concerns in this PR?

SleepWalker avatar Oct 27 '23 10:10 SleepWalker