website
website copied to clipboard
asyncapi
fix: added translation for testimonial data of Homepage
Description
- The testimonial data of Homepage was not getting translated earlier.
- I have added the translation text to respective landing-page.json files for both the languages.
- Instead of directly using the text I have fetched the text from .json files for the testimonial section.
Related issue(s) Resolves Issue #2039
Before
After
Deploy Preview for asyncapi-website ready!
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | d3e1d8dc74498255edd31f139ff1b8655f0aa445 |
| Latest deploy log | https://app.netlify.com/sites/asyncapi-website/deploys/65e754dac8cb6e0008e0a311 |
| Deploy Preview | https://deploy-preview-2724--asyncapi-website.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
⚡️ Lighthouse report for the changes in this PR:
| Category | Score |
|---|---|
| 🔴 Performance | 30 |
| 🟢 Accessibility | 98 |
| 🟢 Best practices | 92 |
| 🟢 SEO | 100 |
| 🔴 PWA | 33 |
Lighthouse ran on https://deploy-preview-2724--asyncapi-website.netlify.app/
Keeping testimonials in the English language was intentional as people give feedback about a product in their native language and expressions. If we translate that thing, it would feel like the testimonials are just another marketing piece that is dubbed into each language irrespective of the original text.
wdyt @derberg, @akshatnema ?
