parser-js icon indicating copy to clipboard operation
parser-js copied to clipboard

fix: upgrade @asyncapi/specs

Open jonaslagoni opened this issue 3 years ago • 5 comments

Description This PR upgrades the @asyncapi/specs library to the new v3.

One important note is, that with the new @asyncapi/specs package, the schema for validating JSON Schema's has to be removed in validation libraries. Why?

Long story short, because the AsyncAPI JSON Schema documents are written with a specific meta schema. That meta schema, is already loaded by Ajv, and when you try to load the bundled AsyncAPI JSON Schema, it now contains that same meta schema, because we use it for payload validation. And Ajv does NOT like to load duplicate schemas and simply throw an error and cannot validate documents.

Related issue(s) Blocked by https://github.com/asyncapi/spec-json-schemas/pull/128

jonaslagoni avatar Dec 09 '21 15:12 jonaslagoni

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Dec 10 '21 11:12 sonarqubecloud[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Apr 06 '22 10:04 sonarqubecloud[bot]

PR is ready

jonaslagoni avatar May 16 '22 17:05 jonaslagoni

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jun 08 '22 14:06 sonarqubecloud[bot]

@jonaslagoni sorry for being so late 😓 please solve conflicts and I can accept

derberg avatar Aug 18 '22 08:08 derberg

@jonaslagoni sorry for being so late 😓 please solve conflicts and I can accept

Done 👍

jonaslagoni avatar Sep 13 '22 12:09 jonaslagoni

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 13 '22 12:09 sonarqubecloud[bot]

:tada: This PR is included in version 1.15.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

asyncapi-bot avatar Sep 13 '22 19:09 asyncapi-bot

:tada: This PR is included in version 2.0.0-next-major.18 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

asyncapi-bot avatar Apr 24 '23 09:04 asyncapi-bot