modelina icon indicating copy to clipboard operation
modelina copied to clipboard

feat: add python generator

Open jonaslagoni opened this issue 3 years ago • 1 comments

Description This PR extends the already existing work from @mahakporwal02 in https://github.com/asyncapi/modelina/pull/604 and adds a python generator for both class and enums.

cc @liquidautumn @niraveen as you showed interest in the other PR, I am just pinging you in case you wish to review it 🙂

Related issue(s) Fixes https://github.com/asyncapi/modelina/issues/49

jonaslagoni avatar Aug 11 '22 23:08 jonaslagoni

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Aug 12 '22 00:08 sonarqubecloud[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Sep 16 '22 13:09 sonarqubecloud[bot]

Accept but I don't know Python so please wait for other reviewers :)

Why? 😄 There was no objections in the last pr and we have Black Box tests to ensure it works.

If something else is desired from the models we get those requests down the line. So i dont see any reason to wait 😄 Unless you know someone who knows python that wants to review it 🤔?

jonaslagoni avatar Sep 21 '22 10:09 jonaslagoni

Gonna take the decision to just merge this now, as we can always backtrack in next generation if something is completely wrong.

jonaslagoni avatar Sep 22 '22 14:09 jonaslagoni

:tada: This PR is included in version 1.0.0-next.8 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

asyncapi-bot avatar Sep 22 '22 14:09 asyncapi-bot