modelina icon indicating copy to clipboard operation
modelina copied to clipboard

chore: add template for new generators

Open jonaslagoni opened this issue 3 years ago • 4 comments

Description This PR adds a template that can be used to easily setup new generators with the bare minimum.

Related issue(s) Fixes https://github.com/asyncapi/modelina/issues/256

jonaslagoni avatar Aug 09 '22 10:08 jonaslagoni

@leigh-johnson as you are the one who most recently added a new generator, if you have the time, I would love to know if you find this useful 🙂

I am gonna try to go through it myself and add the python generator to validate nothing is missing from my side but would be great to have fresh pair of eyes 😄

jonaslagoni avatar Aug 10 '22 11:08 jonaslagoni

:+1: Very nice work, thank you for putting together this template! Couple of quick notes that sprung to mind based on my recent experience writing the RustGenerator. I block out some time to put :eyes: on the Python generator next week if you're looking for feedback.

leigh-johnson avatar Aug 11 '22 16:08 leigh-johnson

👍 Very nice work, thank you for putting together this template! Couple of quick notes that sprung to mind based on my recent experience writing the RustGenerator. I block out some time to put 👀 on the Python generator next week if you're looking for feedback.

Thanks for the feedback!

Would definitely appreciate some eyes on the generator if you have time! Cause my python is non-existing, I can create the generation, but knowing if it's the right output is another talk 😅 You can find the PR here: https://github.com/asyncapi/modelina/pull/863

jonaslagoni avatar Aug 12 '22 00:08 jonaslagoni

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Aug 15 '22 21:08 sonarqubecloud[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Sep 22 '22 14:09 sonarqubecloud[bot]

:tada: This PR is included in version 1.0.0-next.9 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

asyncapi-bot avatar Sep 27 '22 18:09 asyncapi-bot