modelina icon indicating copy to clipboard operation
modelina copied to clipboard

Swagger / OpenAPI input

Open voxpelli opened this issue 4 years ago • 10 comments

Reason/Context

Please try answering few of those questions

  • Why we need this improvement?
    • Swagger / OpenAPI is very similar to AsyncAPI and also builds upon JSON Schema style model definitions
  • How will this change help?
    • Enable more types of conversions and a more complete toolchain for models of all types of sources.

Description

Please try answering few of those questions

  • What changes have to be introduced?
    • Probably the same that was needed to support AsyncAPI on top of JSON Schema
  • Will this be a breaking change?
    • Nope
  • How could it be implemented/designed?
    • Probably the same way that AsyncAPI was

voxpelli avatar Sep 06 '21 15:09 voxpelli

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.

Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

github-actions[bot] avatar Sep 06 '21 15:09 github-actions[bot]

Just leaving this for later:

jonaslagoni avatar Sep 09 '21 09:09 jonaslagoni

@voxpelli do you by any chance have any Swagger/OpenAPI documents you can share, that I can test with? 🙂

Also, do you mind if I ping you, to review the features once they are complete?

jonaslagoni avatar Sep 23 '21 07:09 jonaslagoni

@jonaslagoni Unfortunately nothing public, but I do remember the file I was looking at this time as being a Swagger 2.0 file, so #378 would solve it.

Please ping me when you want a review!

voxpelli avatar Sep 28 '21 15:09 voxpelli

@voxpelli the PR is ready from our side to be merged, if you want to give your review, now is the time 😄 Let me know if you don't have time to review it, so we don't wait in vain 👍

I suggest to download the branch and adapt the example to fit your need - https://github.com/jonaslagoni/generator-model-sdk/tree/feature/swagger_new/examples/swagger2.0-from-object

jonaslagoni avatar Oct 04 '21 14:10 jonaslagoni

:tada: This issue has been resolved in version 0.38.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

asyncapi-bot avatar Oct 12 '21 11:10 asyncapi-bot

Accidentally closed, as we still need to support OpenAPI 3.1, however, I will not focus on this in the near future, if anyone is up to the task, ping me if you want any help 🙂

jonaslagoni avatar Oct 12 '21 11:10 jonaslagoni

This issue has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

github-actions[bot] avatar Mar 23 '22 00:03 github-actions[bot]

Still relevant :)

voxpelli avatar Mar 23 '22 08:03 voxpelli

This issue has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

github-actions[bot] avatar Jul 30 '22 00:07 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

github-actions[bot] avatar Nov 30 '22 00:11 github-actions[bot]

Still relevant :)

voxpelli avatar Nov 30 '22 11:11 voxpelli

This issue has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

github-actions[bot] avatar Mar 31 '23 00:03 github-actions[bot]

still valid? @jonaslagoni @voxpelli

AnimeshKumar923 avatar Jan 15 '24 08:01 AnimeshKumar923

I guess this still holds true:

still need to support OpenAPI 3.1

But maybe better to add that as a new issue? To make it clearer?

voxpelli avatar Jan 15 '24 08:01 voxpelli

Lets keep this closed and focus on https://github.com/asyncapi/modelina/issues/1749 🙂

jonaslagoni avatar Jan 18 '24 21:01 jonaslagoni