generator icon indicating copy to clipboard operation
generator copied to clipboard

Published 20 hours ago • verified publisher icon asyncapi

feat: integrate new parser API

Open magicmatatjahu opened this issue 3 years ago • 1 comments

Description

Integrate new ParserJS API:

  • add new template config field apiVersion.
  • update relevant source code to handle new and old API
  • add some utils

TODO: use released v2 ParserJS, add JSDoc... and tests

Related issue(s) Resolves https://github.com/asyncapi/generator/issues/825 Part of https://github.com/asyncapi/parser-js/issues/481 Blocked by https://github.com/stoplightio/spectral/pull/2284

magicmatatjahu avatar Sep 15 '22 15:09 magicmatatjahu

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Nov 08 '22 16:11 sonarqubecloud[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Nov 14 '22 10:11 sonarqubecloud[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Feb 01 '23 12:02 sonarqubecloud[bot]

@derberg @jonaslagoni I think that we can merge that PR :) I wanna merge it after v2.6.0 release, because then we will have time to fix any potenial bugs before next spec release.

magicmatatjahu avatar Feb 01 '23 12:02 magicmatatjahu

@magicmatatjahu got some conflicts.

jonaslagoni avatar Feb 06 '23 18:02 jonaslagoni

@magicmatatjahu do you think you will still be able to move forward with this PR? 🙏

smoya avatar Mar 09 '23 10:03 smoya

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Mar 20 '23 18:03 sonarqubecloud[bot]

FInal round of review before merging, I solved the conflicts 🙂

jonaslagoni avatar Mar 21 '23 09:03 jonaslagoni

@magicmatatjahu can you please update the branch with latest master changes?

smoya avatar Mar 29 '23 12:03 smoya

As discussed offline via slack DM, @magicmatatjahu is happy with me creating a new PR with all the new changes needed since it can't handle it atm.

This then can be closed in favor of https://github.com/asyncapi/generator/pull/960

cc @jonaslagoni @fmvilas @derberg

smoya avatar May 02 '23 21:05 smoya

closing in favour of https://github.com/asyncapi/generator/pull/960

derberg avatar May 11 '23 14:05 derberg