generator icon indicating copy to clipboard operation
generator copied to clipboard

fix: upgrade dependencies

Open jonaslagoni opened this issue 3 years ago • 5 comments

Description This PR updates most dependencies to address most of the https://github.com/asyncapi/generator/security/dependabot issues.

Jest changes:

  • Renamed genMockFromModule to createMockFromModule -> https://jestjs.io/docs/jest-object#jestcreatemockfrommodulemodulename

Related issue(s) Fixes https://github.com/asyncapi/generator/security/advisories/GHSA-9x5f-xcwh-x6pg

jonaslagoni avatar Jun 17 '22 08:06 jonaslagoni

Still WIP, need to figure out why the test setup no longer works for the new version of Jest.

jonaslagoni avatar Jun 17 '22 08:06 jonaslagoni

When I use the Jest Test explorer in VSCode the tests work as expected 🤔

jonaslagoni avatar Jun 17 '22 09:06 jonaslagoni

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jun 17 '22 10:06 sonarqubecloud[bot]

@derberg do you have any idea as to what might not be working?

jonaslagoni avatar Jun 17 '22 10:06 jonaslagoni

@jonaslagoni dunno, too many updates in one PR. I can only see it is related to unit tests, not integration tests 🤷🏼

I recommend to not make changes to devDependencies as we do not really care about their security issues right?

derberg avatar Jun 22 '22 06:06 derberg

This pull request has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

github-actions[bot] avatar Oct 21 '22 00:10 github-actions[bot]