generator icon indicating copy to clipboard operation
generator copied to clipboard

refactor: add pacote to resolve template name instead of arborist workaround

Open akkshitgupta opened this issue 1 year ago • 14 comments

Description

  • add pacote dependency
  • cleanup arbortis mock and add new one for pacote
  • modify generator.js as suggested

Related issue(s) fixes: #1102

akkshitgupta avatar Feb 06 '24 21:02 akkshitgupta

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Feb 14 '24 11:02 sonarqubecloud[bot]

@derberg @akkshitgupta Can you try deprecating the version of pacote to 15.1.1 in the package.js? I tried it in my copied branch of my forked repository, and it seems to pass the ubuntu test after I deprecated it.

Screenshot 2024-04-18 at 11 56 01 PM

Link to my PR Screenshot 2024-04-18 at 11 56 38 PM

lmgyuan avatar Apr 19 '24 03:04 lmgyuan

let's maybe wait for https://github.com/asyncapi/generator/pull/1069 that will release new generator major release dropping support for older nodes where pacote may have issues?

derberg avatar Apr 22 '24 08:04 derberg

@akkshitgupta please solve merge conflicts

derberg avatar Apr 24 '24 09:04 derberg

Hello @derberg, after resolving conflicts, I am getting this error while running test while it was not the case before merging master. Can you have a look at here

image

akkshitgupta avatar Apr 25 '24 11:04 akkshitgupta

yeah, knows issue, here is a fix https://github.com/asyncapi/generator/pull/1202

derberg avatar Apr 25 '24 11:04 derberg

@akkshitgupta you can update your PR. There is a conflict with package-lock. Just solve it locally by running npm install with verbose flag, of course after first merging latest upstream to your branch, the installation will update package-lock

derberg avatar Apr 29 '24 08:04 derberg

@akkshitgupta please have a look into failing tests

derberg avatar May 13 '24 08:05 derberg

Hey @derberg, its working now. It was an issue on the server side. on the previous update, there some network issue.test failed because of improper dependency installation.

akkshitgupta avatar May 13 '24 09:05 akkshitgupta

@akkshitgupta still failing

derberg avatar May 13 '24 10:05 derberg

Apologies for the delay @derberg. I couldn't pay much attention due to some problems. I looked into it, but couldn't find the reason. i guess, it is failing because of the template version and I don't know how tk solve it.

akkshitgupta avatar May 22 '24 09:05 akkshitgupta

Hey @akkshitgupta please resolve the conflicts, just change the file structure

Gmin2 avatar Jul 01 '24 14:07 Gmin2

Hey @akkshitgupta your test are failing, please resolve it and feel free to ask for any help if yu need

Gmin2 avatar Jul 24 '24 12:07 Gmin2

@akkshitgupta you need to solve conflicts

derberg avatar Jul 29 '24 12:07 derberg

⚠️ No Changeset found

Latest commit: fcc7dcef8104403169e9e0abec8756945214995d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jul 29 '24 17:07 changeset-bot[bot]

@akkshitgupta tests are failing for some strange reasons. Please consult chatgpt that gives some hints that you need to try out. Basically something related to mock and jest config

derberg avatar Jul 30 '24 10:07 derberg

@akkshitgupta do you plan to continue with this one?

derberg avatar Aug 11 '24 18:08 derberg

Apologies @derberg Being occupied, I wasn't able to pay much attention to the issue for a while now, unfortunately. someone else can take it up.

akkshitgupta avatar Aug 12 '24 17:08 akkshitgupta