generator
generator copied to clipboard
refactor: add pacote to resolve template name instead of arborist workaround
Description
- add
pacotedependency - cleanup
arbortismock and add new one forpacote - modify
generator.jsas suggested
Related issue(s) fixes: #1102
Quality Gate passed
Issues
0 New issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
@derberg @akkshitgupta Can you try deprecating the version of pacote to 15.1.1 in the package.js? I tried it in my copied branch of my forked repository, and it seems to pass the ubuntu test after I deprecated it.
let's maybe wait for https://github.com/asyncapi/generator/pull/1069 that will release new generator major release dropping support for older nodes where pacote may have issues?
@akkshitgupta please solve merge conflicts
Hello @derberg, after resolving conflicts, I am getting this error while running test while it was not the case before merging master. Can you have a look at here
yeah, knows issue, here is a fix https://github.com/asyncapi/generator/pull/1202
@akkshitgupta you can update your PR. There is a conflict with package-lock. Just solve it locally by running npm install with verbose flag, of course after first merging latest upstream to your branch, the installation will update package-lock
@akkshitgupta please have a look into failing tests
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
Hey @derberg, its working now. It was an issue on the server side. on the previous update, there some network issue.test failed because of improper dependency installation.
@akkshitgupta still failing
Apologies for the delay @derberg. I couldn't pay much attention due to some problems. I looked into it, but couldn't find the reason. i guess, it is failing because of the template version and I don't know how tk solve it.
Hey @akkshitgupta please resolve the conflicts, just change the file structure
Hey @akkshitgupta your test are failing, please resolve it and feel free to ask for any help if yu need
@akkshitgupta you need to solve conflicts
⚠️ No Changeset found
Latest commit: fcc7dcef8104403169e9e0abec8756945214995d
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
@akkshitgupta tests are failing for some strange reasons. Please consult chatgpt that gives some hints that you need to try out. Basically something related to mock and jest config
@akkshitgupta do you plan to continue with this one?
Apologies @derberg Being occupied, I wasn't able to pay much attention to the issue for a while now, unfortunately. someone else can take it up.