cli

cli copied to clipboard

Reason/Context

This PR introduced automation for publishing of MacOS pkg file. It was also designed in the way that it should be easy to plug in generation of installer files for Windows and Linux.

This issue is for folks that work on Windows machine and can do some local testing to check if all works as expected

Description

• First make sure installer generation works:
  • run npm run pack:windows
  • installer should be produced in dist directory. Try to install CLI using it
• Then open a PR with the following changes
  • Uncomment this part in the artifact publishing job: https://github.com/asyncapi/cli/blob/master/.github/workflows/upload-release-assets.yml#L22-L25 and modify as much as needed
  • I don't know what will be the name of the generated installer, so you will probably have to refactor existing script for MacOS installer renaming -> https://github.com/asyncapi/cli/blob/master/scripts/macosPackRename.js
  • Update Readme instructions on how to quickly install CLI with new installer -> https://github.com/asyncapi/cli#installation

/help

Hello, @derberg! 👋🏼

I'm Genie from the magic lamp. Looks like somebody needs a hand! 🆘

At the moment the following comments are supported in issues:

• /good-first-issue {js | ts | java | go | docs | design | ci-cd} or /gfi {js | ts | java | go | docs | design | ci-cd} - label an issue as a good first issue. example: /gfi js or /good-first-issue ci-cd

/gfi ci-cd

@derberg for windows should we have a .msi installer or use some package manager like chocolatey?

@Souvikns for chocolatey we have this issue https://github.com/asyncapi/cli/issues/304 as work is different than the one described here, and definitely not easy good first issue.

and yes, afaik, https://github.com/oclif/oclif#oclif-pack-win produces .msi but only Windows user can confirm.

I think we need both. Just like with my initial work on MacOS, I worked on brew and also pkg for those that do not use brew

I tested it and it works, we just need to install p7zip and nsis to run the pack:windows command.

I will just wait for https://github.com/asyncapi/cli/pull/325 and then open a PR for this

@derberg I am getting this error while running npm run pack:win I am unable to find shasum for windows.

This issue has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

@Souvikns hey man, since we use latest oclif, maybe you could give it another try?

Will do 👍🏼

@derberg now everything runs, and we get two .exe files, and it looks like it is the installer.

:tada: This issue has been resolved in version 0.40.0 :tada:

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot :package::rocket: