extension-helpers icon indicating copy to clipboard operation
extension-helpers copied to clipboard

Add documentation and tests for setup_helpers.pkg_config

Open astrofrog opened this issue 6 years ago • 5 comments

The setup_helpers.pkg_config function is used in several of astropy's setup_package.py files, so we should keep it here, but it isn't tested or documented, so that will need to be fixed.

astrofrog avatar Jan 20 '19 20:01 astrofrog

The function is simple enough, so I'm not sure if it is worth changing, but there is a python package wrapping pkg-config: https://github.com/matze/pkgconfig I saw it used by some package I don't remember. It is a single file so it could be bundled, which would also remove the need to test and document our version.

saimn avatar Dec 18 '19 15:12 saimn

Oh interesting! Actually if we want to go down that road I suggest we just remove that from extension-helpers and have packages add pkgconfig to their pyproject.toml and use it directly. Is there any reason not to do that?

astrofrog avatar Dec 18 '19 16:12 astrofrog

Oh yes indeed, that would be even simpler.

saimn avatar Dec 18 '19 17:12 saimn

:+1: for removing everything we can :grinning:

Cadair avatar Dec 19 '19 12:12 Cadair

I won't have time to investigate this in the near future, but if one of you has time to take a look, feel free to open a PR to astropy core to demonstrate how we could use the pkgconfig package instead!

astrofrog avatar Dec 19 '19 12:12 astrofrog