Thomas Robitaille

Results 615 comments of Thomas Robitaille

So I just realized that the main code changes here depend on ``get_distutils_option`` which has since been removed since distutils is deprecated and direct use of setup.py is also deprecated....

Just a quick note that with https://github.com/astropy/extension-helpers/pull/33 we can use extension helpers with setup.cfg only projects. I would prefer simply advocating that the option to Extension for the limited API...

Ah yes my bad, we should just parse the config file directly to check for the option

@lpsinger - see here: https://github.com/astropy/extension-helpers/blob/55b7859e08d4cf711ab3037ca7df1ab64b59c922/extension_helpers/__init__.py#L17-L21 For an example of how we parse an option from ``setup.cfg``

@lpsinger just to check, is this something you might have time to work on in the near future? If not, one of us could maybe try and wrap it up...

@lpsinger - just to check, is this something you would have time to work on?

Just a note that I started experimenting with Cython and the limited API and I can't get it to work even with a simple example: https://groups.google.com/g/cython-users/c/-hasuL2VEdo/m/LFaf70PYAwAJ?utm_medium=email&utm_source=footer This is even with...

@lpsinger - are you still interested in trying to tidy up this PR? I think this would be very useful for some projects, and now that Cython supports it we...

Thanks for the report! Another possible fix that would avoid having to call ``os.remove`` would be to check if the destination file is the same as the file being copied...