assertj icon indicating copy to clipboard operation
assertj copied to clipboard

Add doesNotContainKey/s to Guava Multimap asserts

Open ryber opened this issue 2 years ago • 7 comments

Behavior matches the asserts for regular java.util Map asserts in core.

ryber avatar Jan 15 '24 14:01 ryber

Thanks @ryber, we will review your PR shortly !

joel-costigliola avatar Jan 15 '24 21:01 joel-costigliola

Thanks @ryber, first round of code review done, mostly minor stuff ;-)

joel-costigliola avatar Jan 15 '24 21:01 joel-costigliola

@joel-costigliola feedback pushed up on its own commit. If you would rather I squash them and force push to the branch I can, or you can squash on merge, or you can leave them as different commits of course. I was not sure what your preference was. I think I got everything 😄

ryber avatar Jan 15 '24 22:01 ryber

We usually squash the commits into one to make logical commits, cool if you do it but no problem if you let us

joel-costigliola avatar Jan 15 '24 22:01 joel-costigliola

thanks @scordio updated with feedback applied

ryber avatar Jan 16 '24 15:01 ryber

Thanks for your first contribution, @ryber!

We'll go ahead with the merge after releasing 3.25.2 (expected later this month).

scordio avatar Jan 16 '24 16:01 scordio

@scordio oh sorry! I didn't catch that you suggested a name change. I went ahead and changed it

ryber avatar Jan 16 '24 16:01 ryber

Thanks for your first contribution, @ryber!

scordio avatar Mar 01 '24 14:03 scordio