multer-google-storage icon indicating copy to clipboard operation
multer-google-storage copied to clipboard

keyFilename should not be mandatory

Open ranhsd opened this issue 4 years ago • 1 comments

Hi, I noticed that when you create a new storage provider the keyFilename must contain the path to the json key file in GCP. I wanted to let you know that this key file is not mandatory. If you run your service (App engine, Cloud run for instance) on GCP then you can grant a role to the service account so it can access GCS without sending the key file.

If you use the getSignedUrl in your code then you need to grant the Service Account Token Creator in addition to the GCS roles

Thanks.

ranhsd avatar Jun 27 '21 07:06 ranhsd

This basically makes the code unusable to be. Shame.

mike-hogan avatar Mar 24 '23 08:03 mike-hogan