drupal-mode

drupal-mode copied to clipboard

@senda-akiha has archive flymake-phpcs. You probably should stop requiring it in drupal-mode.

Also see https://github.com/melpa/melpa/issues/7225.

Issue Label Bot is not confident enough to auto-label this issue. See dashboard for more details.

Thank you, @tarsius.

I will look into this (soon hopefully).

Friendly ping :ping_pong:

Hi @tarsius

Thank you for the friendly ping. I actually forgot this issue.

drupal-mode doens't really require flymake-phpcs

It's true that we actually make a require in drupal/flymake-phpcs.el but that file is only loaded after flymake-phpcs is loaded, see drupal-mode.el line 899.

The way drupal-mode supports flymake-phpcs is that if a user has configured flymake-phpcs themselves then we load the file and adds support for it in drupal-mode.

I think this should be safe even now that flymale-phpcs is archived.

But we should probably mention in the documentation that it is archived and that we actually support flycheck.

Best outcome would be if someone(tm) volunteered to maintain flymake-phpcs. Ideally someone who prefers flymake over flycheck. But the package is trivial enough for someone who is at least familiar with it to maintain it. Can't be me since I use neither fly* nor php.