avd icon indicating copy to clipboard operation
avd copied to clipboard

Add CLI to support pathfinder outlier elimination feature for AVT in pathfinder based deployment.

Open ayushmittal-arista opened this issue 1 year ago • 2 comments

Enhancement summary

wlm310(config-profile-afd)#show cli commands | grep -i metric
[no|default] metric order ( loss-rate | latency | jitter | load )


wlm310(config-profile-afd)#show cli commands | grep -i outlier
[no|default] path-selection outlier elimination [ disabled ]
[no|default] path-selection outlier elimination threshold jitter <jitter> milliseconds
[no|default] path-selection outlier elimination threshold latency <latency> milliseconds
[no|default] path-selection outlier elimination threshold load <percentage> percent
[no|default] path-selection outlier elimination threshold loss-rate <percentage> percent

Enable feature ( enabled by default )

evpnsfe1(config)#router adaptive-virtual-topology
evpnsfe1(config-adaptive-virtual-topology)#profile voiceAvt
evpnsfe1(config-profile-voiceAvt)#path-selection outlier elimination 

Disable feature

evpnsfe1(config)#router adaptive-virtual-topology
evpnsfe1(config-adaptive-virtual-topology)#profile voiceAvt
evpnsfe1(config-profile-voiceAvt)#path-selection outlier elimination disabled

Configure outlier threshold

evpnsfe1(config)#router adaptive-virtual-topology
evpnsfe1(config-adaptive-virtual-topology)#profile voiceAvt
evpnsfe1(config-profile-voiceAvt)#path-selection outlier elimination threshold ?
  jitter     Configure jitter threshold
  latency    Configure latency threshold
  loss-rate  Configure loss-rate threshold
evpnsfe1(config-profile-voiceAvt)#path-selection outlier elimination threshold latency ?
  <0-10000>  millisecond

evpnsfe1(config-profile-voiceAvt)#path-selection outlier elimination threshold jitter ?
  <0-10000>  millisecond

evpnsfe1(config-profile-voiceAvt)#path-selection outlier elimination threshold loss-rate ?
  <0.00-100.00>  percentage

metric-order CLI

evpnsfe1(config)#router adaptive-virtual-topology
evpnsfe1(config-adaptive-virtual-topology)#profile voiceAvt
evpnsfe1(config-profile-voiceAvt)#metric order ?
  jitter     Prefer paths with lowest jitter
  latency    Prefer paths with lowest latency
  load       Prefer paths with lowest load
  loss-rate  Prefer paths with lowest loss-rate

evpnsfe1(config-profile-voiceAvt)#metric order latency

Which component of AVD is impacted

eos_cli_config_gen

Use case example

needed for pathfinder work

Describe the solution you would like

Implement all cli required for the feature

Describe alternatives you have considered

No response

Additional context

No response

Contributing Guide

  • [X] I agree to follow this project's Code of Conduct

ayushmittal-arista avatar Jul 23 '24 09:07 ayushmittal-arista

metric order ( loss-rate | latency | jitter | load ) :-> Even though the CLI accepts only one keyword right now, it might be extended in future to allow multiple metrics. i.e metric order loss-rate jitter ( Not not, but in future maybe ) As such schema can be a list of strings instead of single string, Something like

metric_order:
        type: list
        items:
          type: str
          valid_values:
          - loss-rate
          - ...
          description: Metric preferred

Also in description, and validation it should be mentioned/handled that list only have 1 element, for now.

ayushmittal-arista avatar Jul 30 '24 09:07 ayushmittal-arista

On hold as command is not supported yet

MaheshGSLAB avatar Oct 17 '24 10:10 MaheshGSLAB

@MaheshGSLAB Supported in the latest release already

pmprado avatar Nov 07 '24 18:11 pmprado

It was not supported when the comment was added.

Guillaume

On Thu 7 Nov 2024 at 19:12, pmprado @.***> wrote:

@MaheshGSLAB https://github.com/MaheshGSLAB Supported in the latest release already

— Reply to this email directly, view it on GitHub https://github.com/aristanetworks/avd/issues/4240#issuecomment-2462917218, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAW6HPRRLVNJZ7DDIVFAUNTZ7OUQLAVCNFSM6AAAAABLJ7QKSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRSHEYTOMRRHA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

gmuloc avatar Nov 07 '24 18:11 gmuloc

It was not supported when the comment was added. Guillaume On Thu 7 Nov 2024 at 19:12, pmprado @.> wrote: @MaheshGSLAB https://github.com/MaheshGSLAB Supported in the latest release already — Reply to this email directly, view it on GitHub <#4240 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAW6HPRRLVNJZ7DDIVFAUNTZ7OUQLAVCNFSM6AAAAABLJ7QKSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRSHEYTOMRRHA . You are receiving this because you are subscribed to this thread.Message ID: @.>

Sure, I didn't mean to say Mahesh was wrong :) Just providing an update to the hold

pmprado avatar Nov 07 '24 18:11 pmprado