avd icon indicating copy to clipboard operation
avd copied to clipboard

Feat(eos_cli_config_gen): Add support for disabling ipv4 unicast as the default mode for BGP

Open pvinci-arista opened this issue 3 years ago • 1 comments

Enhancement summary

Add support for ip4v_unicast_default key under bgp.

bgp:
  ip4v_unicast_default: < true | false | default -> true >

to control rendering:

router bgp 1
   no bgp default ipv4-unicast
!
end

Which component of AVD is impacted

eos_cli_config_gen

Use case example

please detail your use case

Describe the solution you would like

Render the cli from a distinct key in the model.

Describe alternatives you have considered

This is currently supported with the the addition of a cli line under the bgp_defaults key.

Additional context

No response

Contributing Guide

  • [X] I agree to follow this project's Code of Conduct

pvinci-arista avatar Jun 01 '22 16:06 pvinci-arista

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 15 days

github-actions[bot] avatar Aug 31 '22 00:08 github-actions[bot]

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 15 days

github-actions[bot] avatar Nov 30 '22 00:11 github-actions[bot]

This can be achieved with bgp_defaults

image

Add the command directly under this hood. Meanwhile I will add the feature.

tgodaA avatar Dec 14 '22 17:12 tgodaA

Thanks!

Yes! I do that today to render the config, and it works great! The reason a key is valuable is that I don't have to walk the list to understand the intent of the configuration when trying to validate the configs.

pvinci-arista avatar Dec 14 '22 18:12 pvinci-arista

Note that implementing this would need to add some modification in some of the BGP overlay logic where we explicitly disable some peer-groups in ipv4 address family which will be useless with this turned on.

gmuloc avatar Dec 15 '22 12:12 gmuloc

This issue is stale because it has been open 90 days with no activity. The issue will be reviewed by a maintainer and may be closed

github-actions[bot] avatar Mar 16 '23 00:03 github-actions[bot]

Closing this request because this is achieved through bgp_defaults key.

tgodaA avatar May 08 '23 13:05 tgodaA

Will be addressed by https://github.com/aristanetworks/ansible-avd/pull/2799

ClausHolbechArista avatar May 09 '23 09:05 ClausHolbechArista