open-props icon indicating copy to clipboard operation
open-props copied to clipboard

`<details>` & `<button>` need minor alignment

Open argyleink opened this issue 3 years ago • 2 comments

they are close but not the same, should be closer probably? in style that is.

argyleink avatar Feb 09 '22 06:02 argyleink

Maybe make <button> more like <summary>? https://codepen.io/hchiam/pen/dyZQbqb Since <details> typically have a <summary>, then <button> should be styled more like <summary>?

hchiam avatar Mar 01 '22 04:03 hchiam

awesome start @hchiam! ❤️ after studying your pen, i forked it and jotted down some code thoughts: https://codepen.io/argyleink/pen/qBVGOgJ

i think aligning to the button is best, but there's aspects of the button that dont need to be shared, like the hover effect. cant tell what styles should move up into normalize out of buttons or to keep in buttons and just duplicate some values..? hopefully my thoughts help clear up the intent too! i was comparing things to the button styles recently shipped as an extra bundle, and i totally didnt make that clear in the issue.

Screen Shot 2022-03-07 at 10 05 44 PM

argyleink avatar Mar 08 '22 06:03 argyleink