argo-rollouts icon indicating copy to clipboard operation
argo-rollouts copied to clipboard

fix: truncate analysis job name if needed

Open kostis-codefresh opened this issue 10 months ago • 4 comments

Fixes https://github.com/argoproj/argo-rollouts/issues/795

Checklist:

  • [X] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • [X] The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • [X] I've signed my commits with DCO
  • [X] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • [X] My builds are green. Try syncing with master if they are not.
  • [X] My organization is added to USERS.md.

kostis-codefresh avatar Jun 04 '25 15:06 kostis-codefresh

Published E2E Test Results

  4 files    4 suites   3h 15m 2s ⏱️ 115 tests 104 ✅  7 💤 4 ❌ 464 runs  432 ✅ 28 💤 4 ❌

For more details on these failures, see this check.

Results for commit e746339f.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jun 04 '25 15:06 github-actions[bot]

Published Unit Test Results

2 314 tests   2 314 ✅  3m 0s ⏱️   129 suites      0 💤     1 files        0 ❌

Results for commit e746339f.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jun 04 '25 15:06 github-actions[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
46.6% Duplication on New Code (required ≤ 40%)

See analysis details on SonarQube Cloud

sonarqubecloud[bot] avatar Jun 06 '25 09:06 sonarqubecloud[bot]

@zachaller the code duplication (SonarCloud) is in the unit tests. Let me know if this is indeed a problem or not.

kostis-codefresh avatar Jun 06 '25 11:06 kostis-codefresh

When is the next argo rollouts release? I ran into this issue today, saw it was fixed, but there hasn't yet been a release incorporating this fix yet.

voidlily avatar Aug 20 '25 22:08 voidlily

When is the next argo rollouts release? I ran into this issue today, saw it was fixed, but there hasn't yet been a release incorporating this fix yet.

We are also still facing this issue. How to deploy this fix in our environment

harikasiddanathi avatar Sep 16 '25 11:09 harikasiddanathi