argo-cd icon indicating copy to clipboard operation
argo-cd copied to clipboard

fix: show full error message from git fetch command #4441

Open mnacharov opened this issue 3 years ago • 1 comments

Description:

Run git fetch command to receive full error message, since go-git package saves only first line from standard output

Closes #4441

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • [x] (b) this is a bug fix
  • [x] The title of the PR states what changed and the related issues number (used for the release note).
  • [x] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • [x] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • [ ] Does this PR require documentation updates?
  • [ ] I've updated documentation as required by this PR.
  • [ ] Optional. My organization is added to USERS.md.
  • [x] I have signed off all my commits as required by DCO
  • [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • [ ] My build is green (troubleshooting builds).

mnacharov avatar Sep 13 '22 22:09 mnacharov

Codecov Report

Base: 45.69% // Head: 46.16% // Increases project coverage by +0.46% :tada:

Coverage data is based on head (ab5443d) compared to base (ebf1d72). Patch coverage: 16.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10582      +/-   ##
==========================================
+ Coverage   45.69%   46.16%   +0.46%     
==========================================
  Files         234      234              
  Lines       28508    28252     -256     
==========================================
+ Hits        13027    13042      +15     
+ Misses      13694    13407     -287     
- Partials     1787     1803      +16     
Impacted Files Coverage Δ
reposerver/repository/repository.go 60.76% <16.66%> (-0.28%) :arrow_down:
server/application/logs.go 81.25% <0.00%> (-4.47%) :arrow_down:
pkg/apis/application/v1alpha1/repository_types.go 65.45% <0.00%> (-3.16%) :arrow_down:
pkg/apiclient/apiclient.go 0.84% <0.00%> (-0.11%) :arrow_down:
pkg/apiclient/grpcproxy.go 0.00% <0.00%> (ø)
server/application/application.go 28.71% <0.00%> (+0.78%) :arrow_up:
...is/applicationset/v1alpha1/applicationset_types.go 34.69% <0.00%> (+2.55%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 13 '22 22:09 codecov[bot]